View Issue Details

IDProjectCategoryView StatusLast Update
0000394FakturamaDokumente (Documents)public2017-12-30 13:27
ReporterwuetzalAssigned Torheydenr  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product Version1.6.6 
Target Version1.6.7Fixed in Version1.6.7 
Summary0000394: [FAK-394 (alt)] Löschen von mehreren Artikeln
Description

<p>Hat man in einem Dokument mehrere Artikel selektiert, und möchte diese löschen (entweder über den Button im linken Menü oder im Contextmenu oder über Entf), wird jeweils nur das erste markierte Element entfernt.</p><p>Meiner Meinung nach sollten alle markierten Elemente entfernt werden.</p>

Steps To Reproduce
  1. Neues Dokument anlegen
    <br />
  2. Mehrere Artikel hinzuf&#xFC;gen
    <br />
  3. Mehrere Artikel markieren und l&#xF6;schen.
    <br />
    -> Es wird nur ein Artikel gel&#xF6;scht.
TagsNo tags attached.

Activities

wuetzal

2014-11-23 10:41

viewer   ~0000428

Last edited: 2017-12-30 00:08

<p>Vorschlag:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">
$ svn diff
Index: DeleteDataSetAction.java

--- DeleteDataSetAction.java (Revision 845)
+++ DeleteDataSetAction.java (Arbeitskopie)
@@ -16,6 +16,8 @@
import static</span> com.sebulli.fakturama.Translate._;
+import</span> java.util.Iterator;
+
import</span> org.eclipse.jface.action.Action;
import</span> org.eclipse.jface.viewers.ISelection;
import</span> org.eclipse.jface.viewers.IStructuredSelection;
@@ -134,13 +136,17 @@
<span class="code-comment">// Get the selection
</span> selection = documentEditor.getSite().getSelectionProvider().getSelection();
+
if</span> (selection != null</span> && selection instanceof</span> IStructuredSelection) {

  • <span class="code-object">Object</span> obj = ((IStructuredSelection) selection).getFirstElement();
  • IStructuredSelection iselection = ((IStructuredSelection) selection);
  • for</span> (Iterator iterator = iselection.iterator(); iterator.hasNext();) {
  • <span class="code-object">Object</span> obj = (<span class="code-object">Object</span>)iterator.next();
  • <span class="code-comment">// If we had a selection, delete it
    </span>- if</span> (obj != null</span>) {
  • UniDataSet uds = (UniDataSet) obj;
  • documentEditor.deleteItem(uds);
  • <span class="code-comment">// If we had a selection, delete it
    </span>+ if</span> (obj != null</span>) {
  • UniDataSet uds = (UniDataSet) obj;
  • documentEditor.deleteItem(uds);
  • }
    }
    }
    </pre>
    </div></div>
    <p>und</p>
    <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
    <pre class="code-java">$ svn diff
    Index: DocumentEditor.java

    --- DocumentEditor.java (Revision 845)
    +++ DocumentEditor.java (Arbeitskopie)
    @@ -19,6 +19,7 @@
    import</span> java.util.ArrayList;
    import</span> java.util.Calendar;
    import</span> java.util.GregorianCalendar;
    +import</span> java.util.Iterator;
    import</span> java.util.List;
    ISelection selection = tableViewerItems.getSelection();
    IStructuredSelection structuredSelection = (IStructuredSelection) selection;
    if</span> (!structuredSelection.isEmpty()) {

  • <span class="code-comment">// get first element ...
    </span>- <span class="code-object">Object</span> firstElement = structuredSelection.getFirstElement();
  • UniDataSet uds = (UniDataSet) firstElement;
  • <span class="code-comment">// delete the item
    </span>- deleteItem(uds);
  • for (Iterator iterator = structuredSelection.iterator(); iterator.hasNext();) {
  • <span class="code-object">Object element = (<span class="code-object">Object) iterator.next();
  • UniDataSet uds = (UniDataSet) element;
  • <span class="code-comment">// delete the item
  • deleteItem(uds);
  • }
    <span class="code-comment">// Renumber all Items
    RenumberItems();
    </pre>
    </div></div>

rheydenr

2014-11-23 13:52

administrator   ~0000429

Last edited: 2017-12-30 00:08

<p>Hallo Alex, besten Dank für den Patch. Ich werde das mal testweise einbauen, wenn's paßt gibt's das dann in der nächsten Version.</p>

rheydenr

2015-06-18 14:00

administrator   ~0000430

Last edited: 2017-12-30 00:08

<p>Vorgang wurde geschlossen.</p>

Issue History

Date Modified Username Field Change
2017-12-30 00:08 rheydenr New Issue
2017-12-30 00:08 rheydenr Assigned To => rheydenr
2017-12-30 00:08 rheydenr Note Added: 0000428
2017-12-30 00:08 rheydenr Note Added: 0000429
2017-12-30 00:08 rheydenr Note Added: 0000430
2017-12-30 00:08 rheydenr Steps to Reproduce Updated
2017-12-30 13:27 rheydenr Fixed in Version 0.0 => 1.6.7
2017-12-30 13:27 rheydenr Target Version 0.0 =>
2017-12-30 13:27 rheydenr Description Updated
2017-12-30 13:27 rheydenr Steps to Reproduce Updated